Commit 24d64ced authored by Yang Yingliang's avatar Yang Yingliang Committed by Jakub Kicinski
Browse files

net: dsa: realtek: remove unnecessary set_drvdata() 



Remove unnecessary set_drvdata(NULL) function in ->remove(),
the driver_data will be set to NULL in device_unbind_cleanup()
after calling ->remove().

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Acked-by: default avatarAlvin Šipraga <alsi@bang-olufsen.dk>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 68c4e297

drivers/net/dsa/realtek/realtek-mdio.c

+0 −2
Original line number Diff line number Diff line
@@ -245,8 +245,6 @@ static void realtek_mdio_remove(struct mdio_device *mdiodev) 
	/* leave the device reset asserted */

	if (priv->reset)

		gpiod_set_value(priv->reset, 1);



	dev_set_drvdata(&mdiodev->dev, NULL);

}



static void realtek_mdio_shutdown(struct mdio_device *mdiodev)

drivers/net/dsa/realtek/realtek-smi.c

+0 −2
Original line number Diff line number Diff line
@@ -522,8 +522,6 @@ static int realtek_smi_remove(struct platform_device *pdev) 
	if (priv->reset)

		gpiod_set_value(priv->reset, 1);



	platform_set_drvdata(pdev, NULL);



	return 0;

}