Commit 24aecf55 authored by Jimmy Assarsson's avatar Jimmy Assarsson Committed by Marc Kleine-Budde
Browse files

can: kvaser_pciefd: Change return type for kvaser_pciefd_{receive,transmit,set_tx}_irq() 



Change return type to void for kvaser_pciefd_transmit_irq(),
kvaser_pciefd_receive_irq() and kvaser_pciefd_set_tx_irq().
These functions always return zero.

Signed-off-by: default avatarJimmy Assarsson <extja@kvaser.com>
Reviewed-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
Link: https://lore.kernel.org/all/20230529134248.752036-10-extja@kvaser.com


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 488c07b4

drivers/net/can/kvaser_pciefd.c

+3 −7
Original line number Diff line number Diff line
@@ -338,7 +338,7 @@ static void kvaser_pciefd_disable_err_gen(struct kvaser_pciefd_can *can) 
	spin_unlock_irqrestore(&can->lock, irq);

}



static int kvaser_pciefd_set_tx_irq(struct kvaser_pciefd_can *can)

static void kvaser_pciefd_set_tx_irq(struct kvaser_pciefd_can *can)

{

	u32 msk;
@@ -349,8 +349,6 @@ static int kvaser_pciefd_set_tx_irq(struct kvaser_pciefd_can *can) 
	      KVASER_PCIEFD_KCAN_IRQ_TAR;



	iowrite32(msk, can->reg_base + KVASER_PCIEFD_KCAN_IEN_REG);



	return 0;

}



static inline void kvaser_pciefd_set_skb_timestamp(const struct kvaser_pciefd *pcie,
@@ -1456,7 +1454,7 @@ static int kvaser_pciefd_read_buffer(struct kvaser_pciefd *pcie, int dma_buf) 
	return res;

}



static int kvaser_pciefd_receive_irq(struct kvaser_pciefd *pcie)

static void kvaser_pciefd_receive_irq(struct kvaser_pciefd *pcie)

{

	u32 irq;
@@ -1482,10 +1480,9 @@ static int kvaser_pciefd_receive_irq(struct kvaser_pciefd *pcie) 
		dev_err(&pcie->pci->dev, "DMA IRQ error 0x%08X\n", irq);



	iowrite32(irq, pcie->reg_base + KVASER_PCIEFD_SRB_IRQ_REG);

	return 0;

}



static int kvaser_pciefd_transmit_irq(struct kvaser_pciefd_can *can)

static void kvaser_pciefd_transmit_irq(struct kvaser_pciefd_can *can)

{

	u32 irq = ioread32(can->reg_base + KVASER_PCIEFD_KCAN_IRQ_REG);
@@ -1503,7 +1500,6 @@ static int kvaser_pciefd_transmit_irq(struct kvaser_pciefd_can *can) 
		netdev_err(can->can.dev, "Rx FIFO overflow\n");



	iowrite32(irq, can->reg_base + KVASER_PCIEFD_KCAN_IRQ_REG);

	return 0;

}



static irqreturn_t kvaser_pciefd_irq_handler(int irq, void *dev)