Commit 243d040a authored by Necip Fazil Yildiran's avatar Necip Fazil Yildiran Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192e: fix kconfig dependency warning for RTLLIB_CRYPTO_TKIP 



When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled, it results in
the following Kbuild warning:

WARNING: unmet direct dependencies detected for CRYPTO_ARC4
  Depends on [n]: CRYPTO [=n]
  Selected by [m]:
  - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]

WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
  Depends on [n]: CRYPTO [=n]
  Selected by [m]:
  - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]

The reason is that RTLLIB_CRYPTO_TKIP selects CRYPTO_ARC4 and
CRYPTO_MICHAEL_MIC without depending on or selecting CRYPTO while both
CRYPTO_ARC4 and CRYPTO_MICHAEL_MIC are subordinate to CRYPTO.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: e0e3dadd ("staging: r8192e: Fix possible error in configuration")
Signed-off-by: default avatarNecip Fazil Yildiran <fazilyildiran@gmail.com>
Link: https://lore.kernel.org/r/20200915093033.20130-1-fazilyildiran@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f08dede

drivers/staging/rtl8192e/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP 
config RTLLIB_CRYPTO_TKIP

	tristate "Support for rtllib TKIP crypto"

	depends on RTLLIB

	select CRYPTO

	select CRYPTO_ARC4

	select CRYPTO_MICHAEL_MIC

	default y