Commit 2417b986 authored by Paul Clements's avatar Paul Clements Committed by Song Liu
Browse files

md/raid1: properly indicate failure when ending a failed write request 



This patch addresses a data corruption bug in raid1 arrays using bitmaps.
Without this fix, the bitmap bits for the failed I/O end up being cleared.

Since we are in the failure leg of raid1_end_write_request, the request
either needs to be retried (R1BIO_WriteError) or failed (R1BIO_Degraded).

Fixes: eeba6809 ("md/raid1: end bio when the device faulty")
Cc: stable@vger.kernel.org # v5.2+
Signed-off-by: default avatarPaul Clements <paul.clements@us.sios.com>
Signed-off-by: default avatarSong Liu <song@kernel.org>
parent f7c7a2f9

drivers/md/raid1.c

+2 −0
Original line number Diff line number Diff line
@@ -478,6 +478,8 @@ static void raid1_end_write_request(struct bio *bio) 
		if (!test_bit(Faulty, &rdev->flags))

			set_bit(R1BIO_WriteError, &r1_bio->state);

		else {

			/* Fail the request */

			set_bit(R1BIO_Degraded, &r1_bio->state);

			/* Finished with this branch */

			r1_bio->bios[mirror] = NULL;

			to_put = bio;