Unverified Commit 24013314 authored by Rob Clark's avatar Rob Clark Committed by Javier Martinez Canillas
Browse files

drm/shmem-helper: Remove errant put in error path 

drm_gem_shmem_mmap() doesn't own this reference, resulting in the GEM
object getting prematurely freed leading to a later use-after-free.

Link: https://syzkaller.appspot.com/bug?extid=c8ae65286134dd1b800d


Reported-by: default avatar <syzbot+c8ae65286134dd1b800d@syzkaller.appspotmail.com>
Fixes: 2194a63a ("drm: Add library for shmem backed GEM objects")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221130185748.357410-2-robdclark@gmail.com
parent d3d6b1bf

drivers/gpu/drm/drm_gem_shmem_helper.c

+1 −3
Original line number Diff line number Diff line
@@ -622,10 +622,8 @@ int drm_gem_shmem_mmap(struct drm_gem_shmem_object *shmem, struct vm_area_struct 
	}



	ret = drm_gem_shmem_get_pages(shmem);

	if (ret) {

		drm_gem_vm_close(vma);

	if (ret)

		return ret;

	}



	vma->vm_flags |= VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP;

	vma->vm_page_prot = vm_get_page_prot(vma->vm_flags);