Commit 23ec111b authored by Norbert Zulinski's avatar Norbert Zulinski Committed by Tony Nguyen
Browse files

i40e: Fix NULL pointer dereference in i40e_dbg_dump_desc 



When trying to dump VFs VSI RX/TX descriptors
using debugfs there was a crash
due to NULL pointer dereference in i40e_dbg_dump_desc.
Added a check to i40e_dbg_dump_desc that checks if
VSI type is correct for dumping RX/TX descriptors.

Fixes: 02e9c290 ("i40e: debugfs interface")
Signed-off-by: default avatarSylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>
Signed-off-by: default avatarNorbert Zulinski <norbertx.zulinski@intel.com>
Signed-off-by: default avatarMateusz Palczewski <mateusz.palczewski@intel.com>
Tested-by: default avatarGurucharan G <gurucharanx.g@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 8aa55ab4

drivers/net/ethernet/intel/i40e/i40e_debugfs.c

+8 −0
Original line number Diff line number Diff line
@@ -553,6 +553,14 @@ static void i40e_dbg_dump_desc(int cnt, int vsi_seid, int ring_id, int desc_n, 
		dev_info(&pf->pdev->dev, "vsi %d not found\n", vsi_seid);

		return;

	}

	if (vsi->type != I40E_VSI_MAIN &&

	    vsi->type != I40E_VSI_FDIR &&

	    vsi->type != I40E_VSI_VMDQ2) {

		dev_info(&pf->pdev->dev,

			 "vsi %d type %d descriptor rings not available\n",

			 vsi_seid, vsi->type);

		return;

	}

	if (type == RING_TYPE_XDP && !i40e_enabled_xdp_vsi(vsi)) {

		dev_info(&pf->pdev->dev, "XDP not enabled on VSI %d\n", vsi_seid);

		return;