Commit 23e085b2 authored by Keith Busch's avatar Keith Busch Committed by Christoph Hellwig
Browse files

nvme: restrict management ioctls to admin 



The passthrough commands already have this restriction, but the other
operations do not. Require the same capabilities for all users as all of
these operations, which include resets and rescans, can be disruptive.

Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent a8eb6c1b

drivers/nvme/host/ioctl.c

+6 −0
Original line number Diff line number Diff line
@@ -764,11 +764,17 @@ long nvme_dev_ioctl(struct file *file, unsigned int cmd, 
	case NVME_IOCTL_IO_CMD:

		return nvme_dev_user_cmd(ctrl, argp);

	case NVME_IOCTL_RESET:

		if (!capable(CAP_SYS_ADMIN))

			return -EACCES;

		dev_warn(ctrl->device, "resetting controller\n");

		return nvme_reset_ctrl_sync(ctrl);

	case NVME_IOCTL_SUBSYS_RESET:

		if (!capable(CAP_SYS_ADMIN))

			return -EACCES;

		return nvme_reset_subsystem(ctrl);

	case NVME_IOCTL_RESCAN:

		if (!capable(CAP_SYS_ADMIN))

			return -EACCES;

		nvme_queue_scan(ctrl);

		return 0;

	default: