Commit 23d99baf authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

PCI: Use driver_set_override() instead of open-coding 



Use a helper to set driver_override to the reduce amount of duplicated
code.  Make the driver_override field const char, because it is not
modified by the core and it matches other subsystems.

Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220419113435.246203-6-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 01ed1002

drivers/pci/pci-sysfs.c

+4 −24
Original line number Diff line number Diff line
@@ -567,31 +567,11 @@ static ssize_t driver_override_store(struct device *dev, 
				     const char *buf, size_t count)

{

	struct pci_dev *pdev = to_pci_dev(dev);

	char *driver_override, *old, *cp;



	/* We need to keep extra room for a newline */

	if (count >= (PAGE_SIZE - 1))

		return -EINVAL;



	driver_override = kstrndup(buf, count, GFP_KERNEL);

	if (!driver_override)

		return -ENOMEM;



	cp = strchr(driver_override, '\n');

	if (cp)

		*cp = '\0';



	device_lock(dev);

	old = pdev->driver_override;

	if (strlen(driver_override)) {

		pdev->driver_override = driver_override;

	} else {

		kfree(driver_override);

		pdev->driver_override = NULL;

	}

	device_unlock(dev);

	int ret;



	kfree(old);

	ret = driver_set_override(dev, &pdev->driver_override, buf, count);

	if (ret)

		return ret;



	return count;

}

include/linux/pci.h

+5 −1
Original line number Diff line number Diff line
@@ -516,7 +516,11 @@ struct pci_dev { 
	u16		acs_cap;	/* ACS Capability offset */

	phys_addr_t	rom;		/* Physical address if not from BAR */

	size_t		romlen;		/* Length if not from BAR */

	char		*driver_override; /* Driver name to force a match */

	/*

	 * Driver name to force a match.  Do not set directly, because core

	 * frees it.  Use driver_set_override() to set or clear it.

	 */

	const char	*driver_override;



	unsigned long	priv_flags;	/* Private flags for the PCI driver */