Commit 23befe49 authored by Hyeongseok Kim's avatar Hyeongseok Kim Committed by Namjae Jeon
Browse files

exfat: improve write performance when dirsync enabled 



Degradation of write speed caused by frequent disk access for cluster
bitmap update on every cluster allocation could be improved by
selective syncing bitmap buffer. Change to flush bitmap buffer only
for the directory related operations.

Signed-off-by: default avatarHyeongseok Kim <hyeongseok@gmail.com>
Acked-by: default avatarSungjong Seo <sj1557.seo@samsung.com>
Signed-off-by: default avatarNamjae Jeon <namjae.jeon@samsung.com>
parent 654762df

fs/exfat/balloc.c

+2 −2
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ void exfat_free_bitmap(struct exfat_sb_info *sbi) 
	kfree(sbi->vol_amap);

}



int exfat_set_bitmap(struct inode *inode, unsigned int clu)

int exfat_set_bitmap(struct inode *inode, unsigned int clu, bool sync)

{

	int i, b;

	unsigned int ent_idx;
@@ -154,7 +154,7 @@ int exfat_set_bitmap(struct inode *inode, unsigned int clu) 
	b = BITMAP_OFFSET_BIT_IN_SECTOR(sb, ent_idx);



	set_bit_le(b, sbi->vol_amap[i]->b_data);

	exfat_update_bh(sbi->vol_amap[i], IS_DIRSYNC(inode));

	exfat_update_bh(sbi->vol_amap[i], sync);

	return 0;

}

fs/exfat/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -320,7 +320,7 @@ int exfat_alloc_new_dir(struct inode *inode, struct exfat_chain *clu) 


	exfat_chain_set(clu, EXFAT_EOF_CLUSTER, 0, ALLOC_NO_FAT_CHAIN);



	ret = exfat_alloc_cluster(inode, 1, clu);

	ret = exfat_alloc_cluster(inode, 1, clu, IS_DIRSYNC(inode));

	if (ret)

		return ret;

fs/exfat/exfat_fs.h

+2 −2
Original line number Diff line number Diff line
@@ -389,7 +389,7 @@ int exfat_clear_volume_dirty(struct super_block *sb); 
#define exfat_get_next_cluster(sb, pclu) exfat_ent_get(sb, *(pclu), pclu)



int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc,

		struct exfat_chain *p_chain);

		struct exfat_chain *p_chain, bool sync_bmap);

int exfat_free_cluster(struct inode *inode, struct exfat_chain *p_chain);

int exfat_ent_get(struct super_block *sb, unsigned int loc,

		unsigned int *content);
@@ -408,7 +408,7 @@ int exfat_count_num_clusters(struct super_block *sb, 
/* balloc.c */

int exfat_load_bitmap(struct super_block *sb);

void exfat_free_bitmap(struct exfat_sb_info *sbi);

int exfat_set_bitmap(struct inode *inode, unsigned int clu);

int exfat_set_bitmap(struct inode *inode, unsigned int clu, bool sync);

void exfat_clear_bitmap(struct inode *inode, unsigned int clu, bool sync);

unsigned int exfat_find_free_bitmap(struct super_block *sb, unsigned int clu);

int exfat_count_used_clusters(struct super_block *sb, unsigned int *ret_count);

fs/exfat/fatent.c

+2 −2
Original line number Diff line number Diff line
@@ -320,7 +320,7 @@ int exfat_zeroed_cluster(struct inode *dir, unsigned int clu) 
}



int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc,

		struct exfat_chain *p_chain)

		struct exfat_chain *p_chain, bool sync_bmap)

{

	int ret = -ENOSPC;

	unsigned int num_clusters = 0, total_cnt;
@@ -388,7 +388,7 @@ int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc, 
		}



		/* update allocation bitmap */

		if (exfat_set_bitmap(inode, new_clu)) {

		if (exfat_set_bitmap(inode, new_clu, sync_bmap)) {

			ret = -EIO;

			goto free_cluster;

		}

fs/exfat/inode.c

+2 −1
Original line number Diff line number Diff line
@@ -179,7 +179,8 @@ static int exfat_map_cluster(struct inode *inode, unsigned int clu_offset, 
			return -EIO;

		}



		ret = exfat_alloc_cluster(inode, num_to_be_allocated, &new_clu);

		ret = exfat_alloc_cluster(inode, num_to_be_allocated, &new_clu,

				inode_needs_sync(inode));

		if (ret)

			return ret;