Commit 23b29ed8 authored by Vlad Yasevich's avatar Vlad Yasevich Committed by David S. Miller
Browse files

sctp: Do not leak memory on multiple listen() calls 



SCTP permits multiple listen call and on subsequent calls
we leak he memory allocated for the crypto transforms.

Signed-off-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7dab83de

net/sctp/socket.c

+3 −2
Original line number Diff line number Diff line
@@ -5773,7 +5773,7 @@ int sctp_inet_listen(struct socket *sock, int backlog) 
		goto out;



	/* Allocate HMAC for generating cookie. */

	if (sctp_hmac_alg) {

	if (!sctp_sk(sk)->hmac && sctp_hmac_alg) {

		tfm = crypto_alloc_hash(sctp_hmac_alg, 0, CRYPTO_ALG_ASYNC);

		if (IS_ERR(tfm)) {

			if (net_ratelimit()) {
@@ -5801,6 +5801,7 @@ int sctp_inet_listen(struct socket *sock, int backlog) 
		goto cleanup;



	/* Store away the transform reference. */

	if (!sctp_sk(sk)->hmac)

		sctp_sk(sk)->hmac = tfm;

out:

	sctp_release_sock(sk);