Commit 2343bcdb authored by Zhou Qingyang's avatar Zhou Qingyang Committed by Lyude Paul
Browse files

drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl() 



In nvkm_acr_hsfw_load_bl(), the return value of kmalloc() is directly
passed to memcpy(), which could lead to undefined behavior on failure
of kmalloc().

Fix this bug by using kmemdup() instead of kmalloc()+memcpy().

This bug was found by a static analyzer.

Builds with 'make allyesconfig' show no new warnings,
and our static analyzer no longer warns about this code.

Fixes: 22dcda45 ("drm/nouveau/acr: implement new subdev to replace "secure boot"")
Signed-off-by: default avatarZhou Qingyang <zhou1615@umn.edu>
Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220124165856.57022-1-zhou1615@umn.edu
parent 80ecb5d7

drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c

+5 −4
Original line number Diff line number Diff line
@@ -142,10 +142,11 @@ nvkm_acr_hsfw_load_bl(struct nvkm_acr *acr, const char *name, int ver, 


	hsfw->imem_size = desc->code_size;

	hsfw->imem_tag = desc->start_tag;

	hsfw->imem = kmalloc(desc->code_size, GFP_KERNEL);

	memcpy(hsfw->imem, data + desc->code_off, desc->code_size);



	hsfw->imem = kmemdup(data + desc->code_off, desc->code_size, GFP_KERNEL);

	nvkm_firmware_put(fw);

	if (!hsfw->imem)

		return -ENOMEM;

	else

		return 0;

}