Commit 2342eb1a authored Apr 27, 2021 by Jiapeng Chong Committed by David S. Miller Apr 27, 2021

llc2: Remove redundant assignment to rc



Variable rc is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

net/llc/llc_station.c:86:2: warning: Value stored to 'rc' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3afef8c7

net/llc/llc_station.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -54,7 +54,6 @@ static int llc_station_ac_send_xid_r(struct sk_buff *skb)

		if (!nskb)
		goto out;
		rc = 0;
		llc_pdu_decode_sa(skb, mac_da);
		llc_pdu_decode_ssap(skb, &dsap);
		llc_pdu_header_init(nskb, LLC_PDU_TYPE_U, 0, dsap, LLC_PDU_RSP);
		@@ -83,7 +82,6 @@ static int llc_station_ac_send_test_r(struct sk_buff *skb)

		if (!nskb)
		goto out;
		rc = 0;
		llc_pdu_decode_sa(skb, mac_da);
		llc_pdu_decode_ssap(skb, &dsap);
		llc_pdu_header_init(nskb, LLC_PDU_TYPE_U, 0, dsap, LLC_PDU_RSP);