Unverified Commit 233363ab authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

spi/panel: dt-bindings: drop CPHA and CPOL from common properties 



The spi-cpha and spi-cpol properties are device specific and should be
accepted only if device really needs them.  Drop them from common
spi-peripheral-props.yaml schema, mention in few panel drivers which use
them and include instead in the SPI controller bindings.  The controller
bindings will provide CPHA/CPOL type validation and one place for
description.  Each device schema must list the properties if they are
applicable.

Suggested-by: default avatarJonathan Cameron <jic23@kernel.org>
Suggested-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220722191539.90641-2-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 89fcdd53

Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml

+3 −0
Original line number Diff line number Diff line
@@ -21,6 +21,9 @@ properties: 
  enable-gpios: true

  port: true



  spi-cpha: true

  spi-cpol: true



required:

  - compatible

  - enable-gpios

Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml

+3 −0
Original line number Diff line number Diff line
@@ -42,6 +42,9 @@ properties: 
  panel-height-mm:

    description: physical panel height [mm]



  spi-cpha: true

  spi-cpol: true



required:

  - compatible

  - reg

Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml

+3 −0
Original line number Diff line number Diff line
@@ -23,6 +23,9 @@ properties: 
  backlight: true

  port: true



  spi-cpha: true

  spi-cpol: true



required:

  - compatible

  - reg

Documentation/devicetree/bindings/display/panel/tpo,td.yaml

+3 −0
Original line number Diff line number Diff line
@@ -28,6 +28,9 @@ properties: 
  backlight: true

  port: true



  spi-cpha: true

  spi-cpol: true



required:

  - compatible

  - port

Documentation/devicetree/bindings/spi/spi-controller.yaml

+11 −0
Original line number Diff line number Diff line
@@ -95,6 +95,17 @@ patternProperties: 
    type: object

    $ref: spi-peripheral-props.yaml



    properties:

      spi-cpha:

        $ref: /schemas/types.yaml#/definitions/flag

        description:

          The device requires shifted clock phase (CPHA) mode.



      spi-cpol:

        $ref: /schemas/types.yaml#/definitions/flag

        description:

          The device requires inverse clock polarity (CPOL) mode.



    required:

      - compatible

      - reg