Commit 23274739 authored by Cristian Marussi's avatar Cristian Marussi Committed by Sudeep Holla
Browse files

firmware: arm_scmi: Fix sorting of retrieved clock rates 

During SCMI Clock protocol initialization, after having retrieved from the
SCMI platform all the available discrete rates for a specific clock, the
clock rates array is sorted, unfortunately using a pointer to its end as
a base instead of its start, so that sorting does not work.

Fix invocation of sort() passing as base a pointer to the start of the
retrieved clock rates array.

Link: https://lore.kernel.org/r/20220318092813.49283-1-cristian.marussi@arm.com


Fixes: dccec73d ("firmware: arm_scmi: Keep the discrete clock rates sorted")
Signed-off-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 98f0d68f

drivers/firmware/arm_scmi/clock.c

+2 −1
Original line number Diff line number Diff line
@@ -210,7 +210,8 @@ scmi_clock_describe_rates_get(const struct scmi_protocol_handle *ph, u32 clk_id, 


	if (rate_discrete && rate) {

		clk->list.num_rates = tot_rate_cnt;

		sort(rate, tot_rate_cnt, sizeof(*rate), rate_cmp_func, NULL);

		sort(clk->list.rates, tot_rate_cnt, sizeof(*rate),

		     rate_cmp_func, NULL);

	}



	clk->rate_discrete = rate_discrete;