Commit 231ee8bd authored by Jiapeng Zhong's avatar Jiapeng Zhong Committed by Marcel Holtmann
Browse files

Bluetooth: fix coccicheck warnings debugfs 



Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Reported-by: default avatarAbaci <Robot&lt;abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 219991e6

net/bluetooth/hci_debugfs.c

+40 −40
Original line number Diff line number Diff line
@@ -237,7 +237,7 @@ static int conn_info_min_age_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(conn_info_min_age_fops, conn_info_min_age_get,

DEFINE_DEBUGFS_ATTRIBUTE(conn_info_min_age_fops, conn_info_min_age_get,

			  conn_info_min_age_set, "%llu\n");



static int conn_info_max_age_set(void *data, u64 val)
@@ -265,7 +265,7 @@ static int conn_info_max_age_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(conn_info_max_age_fops, conn_info_max_age_get,

DEFINE_DEBUGFS_ATTRIBUTE(conn_info_max_age_fops, conn_info_max_age_get,

			  conn_info_max_age_set, "%llu\n");



static ssize_t use_debug_keys_read(struct file *file, char __user *user_buf,
@@ -419,7 +419,7 @@ static int voice_setting_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(voice_setting_fops, voice_setting_get,

DEFINE_DEBUGFS_ATTRIBUTE(voice_setting_fops, voice_setting_get,

			  NULL, "0x%4.4llx\n");



static ssize_t ssp_debug_mode_read(struct file *file, char __user *user_buf,
@@ -476,7 +476,7 @@ static int min_encrypt_key_size_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(min_encrypt_key_size_fops,

DEFINE_DEBUGFS_ATTRIBUTE(min_encrypt_key_size_fops,

			  min_encrypt_key_size_get,

			  min_encrypt_key_size_set, "%llu\n");
@@ -491,7 +491,7 @@ static int auto_accept_delay_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(auto_accept_delay_fops, auto_accept_delay_get,

DEFINE_DEBUGFS_ATTRIBUTE(auto_accept_delay_fops, auto_accept_delay_get,

			  auto_accept_delay_set, "%llu\n");



static ssize_t force_bredr_smp_read(struct file *file,
@@ -558,7 +558,7 @@ static int idle_timeout_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(idle_timeout_fops, idle_timeout_get,

DEFINE_DEBUGFS_ATTRIBUTE(idle_timeout_fops, idle_timeout_get,

			  idle_timeout_set, "%llu\n");



static int sniff_min_interval_set(void *data, u64 val)
@@ -586,7 +586,7 @@ static int sniff_min_interval_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(sniff_min_interval_fops, sniff_min_interval_get,

DEFINE_DEBUGFS_ATTRIBUTE(sniff_min_interval_fops, sniff_min_interval_get,

			  sniff_min_interval_set, "%llu\n");



static int sniff_max_interval_set(void *data, u64 val)
@@ -614,7 +614,7 @@ static int sniff_max_interval_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(sniff_max_interval_fops, sniff_max_interval_get,

DEFINE_DEBUGFS_ATTRIBUTE(sniff_max_interval_fops, sniff_max_interval_get,

			  sniff_max_interval_set, "%llu\n");



void hci_debugfs_create_bredr(struct hci_dev *hdev)
@@ -706,7 +706,7 @@ static int rpa_timeout_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(rpa_timeout_fops, rpa_timeout_get,

DEFINE_DEBUGFS_ATTRIBUTE(rpa_timeout_fops, rpa_timeout_get,

			  rpa_timeout_set, "%llu\n");



static int random_address_show(struct seq_file *f, void *p)
@@ -869,7 +869,7 @@ static int conn_min_interval_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(conn_min_interval_fops, conn_min_interval_get,

DEFINE_DEBUGFS_ATTRIBUTE(conn_min_interval_fops, conn_min_interval_get,

			  conn_min_interval_set, "%llu\n");



static int conn_max_interval_set(void *data, u64 val)
@@ -897,7 +897,7 @@ static int conn_max_interval_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(conn_max_interval_fops, conn_max_interval_get,

DEFINE_DEBUGFS_ATTRIBUTE(conn_max_interval_fops, conn_max_interval_get,

			  conn_max_interval_set, "%llu\n");



static int conn_latency_set(void *data, u64 val)
@@ -925,7 +925,7 @@ static int conn_latency_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(conn_latency_fops, conn_latency_get,

DEFINE_DEBUGFS_ATTRIBUTE(conn_latency_fops, conn_latency_get,

			  conn_latency_set, "%llu\n");



static int supervision_timeout_set(void *data, u64 val)
@@ -953,7 +953,7 @@ static int supervision_timeout_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(supervision_timeout_fops, supervision_timeout_get,

DEFINE_DEBUGFS_ATTRIBUTE(supervision_timeout_fops, supervision_timeout_get,

			  supervision_timeout_set, "%llu\n");



static int adv_channel_map_set(void *data, u64 val)
@@ -981,7 +981,7 @@ static int adv_channel_map_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(adv_channel_map_fops, adv_channel_map_get,

DEFINE_DEBUGFS_ATTRIBUTE(adv_channel_map_fops, adv_channel_map_get,

			  adv_channel_map_set, "%llu\n");



static int adv_min_interval_set(void *data, u64 val)
@@ -1009,7 +1009,7 @@ static int adv_min_interval_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(adv_min_interval_fops, adv_min_interval_get,

DEFINE_DEBUGFS_ATTRIBUTE(adv_min_interval_fops, adv_min_interval_get,

			  adv_min_interval_set, "%llu\n");



static int adv_max_interval_set(void *data, u64 val)
@@ -1037,7 +1037,7 @@ static int adv_max_interval_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(adv_max_interval_fops, adv_max_interval_get,

DEFINE_DEBUGFS_ATTRIBUTE(adv_max_interval_fops, adv_max_interval_get,

			  adv_max_interval_set, "%llu\n");



static int min_key_size_set(void *data, u64 val)
@@ -1065,7 +1065,7 @@ static int min_key_size_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(min_key_size_fops, min_key_size_get,

DEFINE_DEBUGFS_ATTRIBUTE(min_key_size_fops, min_key_size_get,

			  min_key_size_set, "%llu\n");



static int max_key_size_set(void *data, u64 val)
@@ -1093,7 +1093,7 @@ static int max_key_size_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(max_key_size_fops, max_key_size_get,

DEFINE_DEBUGFS_ATTRIBUTE(max_key_size_fops, max_key_size_get,

			  max_key_size_set, "%llu\n");



static int auth_payload_timeout_set(void *data, u64 val)
@@ -1121,7 +1121,7 @@ static int auth_payload_timeout_get(void *data, u64 *val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(auth_payload_timeout_fops,

DEFINE_DEBUGFS_ATTRIBUTE(auth_payload_timeout_fops,

			  auth_payload_timeout_get,

			  auth_payload_timeout_set, "%llu\n");