Unverified Commit 2316c11f authored by Amadeusz Sławiński's avatar Amadeusz Sławiński Committed by Mark Brown
Browse files

ASoC: topology: Remove redundant logs 



soc_tplg_add_kcontrol() logs all the failures in detail already.

Signed-off-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Reviewed-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230519195611.4068853-3-amadeuszx.slawinski@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ec5dffcd

sound/soc/soc-topology.c

+3 −9
Original line number Diff line number Diff line
@@ -700,10 +700,8 @@ static int soc_tplg_dbytes_create(struct soc_tplg *tplg, size_t size) 


	/* register control here */

	ret = soc_tplg_add_kcontrol(tplg, &kc, &sbe->dobj.control.kcontrol);

	if (ret < 0) {

		dev_err(tplg->dev, "ASoC: failed to add %s\n", be->hdr.name);

	if (ret < 0)

		goto err;

	}



	list_add(&sbe->dobj.list, &tplg->comp->dobj_list);
@@ -783,10 +781,8 @@ static int soc_tplg_dmixer_create(struct soc_tplg *tplg, size_t size) 


	/* register control here */

	ret = soc_tplg_add_kcontrol(tplg, &kc, &sm->dobj.control.kcontrol);

	if (ret < 0) {

		dev_err(tplg->dev, "ASoC: failed to add %s\n", mc->hdr.name);

	if (ret < 0)

		goto err;

	}



	list_add(&sm->dobj.list, &tplg->comp->dobj_list);
@@ -950,10 +946,8 @@ static int soc_tplg_denum_create(struct soc_tplg *tplg, size_t size) 


	/* register control here */

	ret = soc_tplg_add_kcontrol(tplg, &kc, &se->dobj.control.kcontrol);

	if (ret < 0) {

		dev_err(tplg->dev, "ASoC: could not add kcontrol %s\n", ec->hdr.name);

	if (ret < 0)

		goto err;

	}



	list_add(&se->dobj.list, &tplg->comp->dobj_list);