Commit 23138ead authored by Richard Guy Briggs's avatar Richard Guy Briggs Committed by Paul Moore
Browse files

audit: return on memory error to avoid null pointer dereference 

If there is a memory allocation error when trying to change an audit
kernel feature value, the ignored allocation error will trigger a NULL
pointer dereference oops on subsequent use of that pointer.  Return
instead.

Passes audit-testsuite.
See: https://github.com/linux-audit/audit-kernel/issues/76



Signed-off-by: default avatarRichard Guy Briggs <rgb@redhat.com>
[PM: not necessary (other funcs check for NULL), but a good practice]
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
parent 94d14e3e

kernel/audit.c

+2 −0
Original line number Diff line number Diff line
@@ -1059,6 +1059,8 @@ static void audit_log_feature_change(int which, u32 old_feature, u32 new_feature 
		return;



	ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_FEATURE_CHANGE);

	if (!ab)

		return;

	audit_log_task_info(ab, current);

	audit_log_format(ab, " feature=%s old=%u new=%u old_lock=%u new_lock=%u res=%d",

			 audit_feature_names[which], !!old_feature, !!new_feature,