Commit 2311072d authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: tvp7002: fix uninitialized variable warning 



tvp7002.c: In function 'tvp7002_g_register':
tvp7002.c:691:11: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
  691 |  reg->val = val;
      |  ~~~~~~~~~^~~~~

Just return without setting 'reg' if tvp7002_read returns an error.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 7124ae48

drivers/media/i2c/tvp7002.c

+3 −1
Original line number Diff line number Diff line
@@ -688,9 +688,11 @@ static int tvp7002_g_register(struct v4l2_subdev *sd, 
	int ret;



	ret = tvp7002_read(sd, reg->reg & 0xff, &val);

	if (ret < 0)

		return ret;

	reg->val = val;

	reg->size = 1;

	return ret;

	return 0;

}



/*