Commit 22f8b5df authored by Norbert Ciosek's avatar Norbert Ciosek Committed by Tony Nguyen
Browse files

virtchnl: Fix layout of RSS structures 



Remove padding from RSS structures. Previous layout
could lead to unwanted compiler optimizations
in loops when iterating over key and lut arrays.

Fixes: 65ece6de ("virtchnl: Add missing explicit padding to structures")
Signed-off-by: default avatarNorbert Ciosek <norbertx.ciosek@intel.com>
Tested-by: default avatarKonrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent e43accba

include/linux/avf/virtchnl.h

+0 −2
Original line number Diff line number Diff line
@@ -476,7 +476,6 @@ struct virtchnl_rss_key { 
	u16 vsi_id;

	u16 key_len;

	u8 key[1];         /* RSS hash key, packed bytes */

	u8 pad[1];

};



VIRTCHNL_CHECK_STRUCT_LEN(6, virtchnl_rss_key);
@@ -485,7 +484,6 @@ struct virtchnl_rss_lut { 
	u16 vsi_id;

	u16 lut_entries;

	u8 lut[1];        /* RSS lookup table */

	u8 pad[1];

};



VIRTCHNL_CHECK_STRUCT_LEN(6, virtchnl_rss_lut);