Commit 22e0db42 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

x86/apic: Replace pointless apic:: Dest_logical usage 



All these functions are only used for logical destination mode. So reading
the destination mode mask from the apic structure is a pointless
exercise. Just hand in the proper constant: APIC_DEST_LOGICAL.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarDavid Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20201024213535.443185-7-dwmw2@infradead.org
parent 72161299

arch/x86/kernel/apic/apic_flat_64.c

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ static void _flat_send_IPI_mask(unsigned long mask, int vector) 
	unsigned long flags;



	local_irq_save(flags);

	__default_send_IPI_dest_field(mask, vector, apic->dest_logical);

	__default_send_IPI_dest_field(mask, vector, APIC_DEST_LOGICAL);

	local_irq_restore(flags);

}

arch/x86/kernel/apic/ipi.c

+3 −3
Original line number Diff line number Diff line
@@ -260,7 +260,7 @@ void default_send_IPI_mask_sequence_logical(const struct cpumask *mask, 
	for_each_cpu(query_cpu, mask)

		__default_send_IPI_dest_field(

			early_per_cpu(x86_cpu_to_logical_apicid, query_cpu),

			vector, apic->dest_logical);

			vector, APIC_DEST_LOGICAL);

	local_irq_restore(flags);

}
@@ -279,7 +279,7 @@ void default_send_IPI_mask_allbutself_logical(const struct cpumask *mask, 
			continue;

		__default_send_IPI_dest_field(

			early_per_cpu(x86_cpu_to_logical_apicid, query_cpu),

			vector, apic->dest_logical);

			vector, APIC_DEST_LOGICAL);

		}

	local_irq_restore(flags);

}
@@ -297,7 +297,7 @@ void default_send_IPI_mask_logical(const struct cpumask *cpumask, int vector) 


	local_irq_save(flags);

	WARN_ON(mask & ~cpumask_bits(cpu_online_mask)[0]);

	__default_send_IPI_dest_field(mask, vector, apic->dest_logical);

	__default_send_IPI_dest_field(mask, vector, APIC_DEST_LOGICAL);

	local_irq_restore(flags);

}

arch/x86/kernel/apic/x2apic_cluster.c

+1 −1
Original line number Diff line number Diff line
@@ -61,7 +61,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest) 
		if (!dest)

			continue;



		__x2apic_send_IPI_dest(dest, vector, apic->dest_logical);

		__x2apic_send_IPI_dest(dest, vector, APIC_DEST_LOGICAL);

		/* Remove cluster CPUs from tmpmask */

		cpumask_andnot(tmpmsk, tmpmsk, &cmsk->mask);

	}