Commit 22e06b30 authored by Wolfram Sang's avatar Wolfram Sang
Browse files

i2c: tegra-bpmp: don't modify input variable in xlate_flags 



Since commit bc1c2048 ("i2c: bpmp-tegra: Ignore unknown I2C_M
flags") we don't need to mask out flags and can keep the input variable
as is to save quite some lines.

Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Acked-by: default avatarThierry Reding <treding@nvidia.com>
Tested-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent fd6ddaa0

drivers/i2c/busses/i2c-tegra-bpmp.c

+8 −24
Original line number Diff line number Diff line
@@ -40,45 +40,29 @@ struct tegra_bpmp_i2c { 
 */

static int tegra_bpmp_xlate_flags(u16 flags, u16 *out)

{

	if (flags & I2C_M_TEN) {

	if (flags & I2C_M_TEN)

		*out |= SERIALI2C_TEN;

		flags &= ~I2C_M_TEN;

	}



	if (flags & I2C_M_RD) {

	if (flags & I2C_M_RD)

		*out |= SERIALI2C_RD;

		flags &= ~I2C_M_RD;

	}



	if (flags & I2C_M_STOP) {

	if (flags & I2C_M_STOP)

		*out |= SERIALI2C_STOP;

		flags &= ~I2C_M_STOP;

	}



	if (flags & I2C_M_NOSTART) {

	if (flags & I2C_M_NOSTART)

		*out |= SERIALI2C_NOSTART;

		flags &= ~I2C_M_NOSTART;

	}



	if (flags & I2C_M_REV_DIR_ADDR) {

	if (flags & I2C_M_REV_DIR_ADDR)

		*out |= SERIALI2C_REV_DIR_ADDR;

		flags &= ~I2C_M_REV_DIR_ADDR;

	}



	if (flags & I2C_M_IGNORE_NAK) {

	if (flags & I2C_M_IGNORE_NAK)

		*out |= SERIALI2C_IGNORE_NAK;

		flags &= ~I2C_M_IGNORE_NAK;

	}



	if (flags & I2C_M_NO_RD_ACK) {

	if (flags & I2C_M_NO_RD_ACK)

		*out |= SERIALI2C_NO_RD_ACK;

		flags &= ~I2C_M_NO_RD_ACK;

	}



	if (flags & I2C_M_RECV_LEN) {

	if (flags & I2C_M_RECV_LEN)

		*out |= SERIALI2C_RECV_LEN;

		flags &= ~I2C_M_RECV_LEN;

	}



	return 0;

}