Commit 22dc3789 authored by Tom Rix's avatar Tom Rix Committed by Lee Jones
Browse files

leds: flash: Set variables mvflash_{3,4}ch_regs storage-class-specifier to static 



Smatch reports:

  drivers/leds/flash/leds-qcom-flash.c:103:18: warning:
    symbol 'mvflash_3ch_regs' was not declared. Should it be static?
  drivers/leds/flash/leds-qcom-flash.c:115:18: warning:
    symbol 'mvflash_4ch_regs' was not declared. Should it be static?

These variables are only used locally, so it should be static.

Signed-off-by: default avatarTom Rix <trix@redhat.com>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230317191341.1670660-1-trix@redhat.com
parent 560f2eb7

drivers/leds/flash/leds-qcom-flash.c

+2 −2
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ enum { 
	REG_MAX_COUNT,

};



struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {

static struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {

	REG_FIELD(0x08, 0, 7),			/* status1	*/

	REG_FIELD(0x09, 0, 7),                  /* status2	*/

	REG_FIELD(0x0a, 0, 7),                  /* status3	*/
@@ -112,7 +112,7 @@ struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = { 
	REG_FIELD(0x4c, 0, 2),                  /* chan_en	*/

};



struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {

static struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {

	REG_FIELD(0x06, 0, 7),			/* status1	*/

	REG_FIELD(0x07, 0, 6),			/* status2	*/

	REG_FIELD(0x09, 0, 7),			/* status3	*/