Commit 22cdb493 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by David S. Miller
Browse files

net: mscc: ocelot: unregister net devices on unbind 



This driver was not unregistering its network interfaces on unbind.
Now it is.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarHoratiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Tested-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7c411799

drivers/net/ethernet/mscc/ocelot_vsc7514.c

+21 −0
Original line number Diff line number Diff line
@@ -896,6 +896,26 @@ static struct ptp_clock_info ocelot_ptp_clock_info = { 
	.enable		= ocelot_ptp_enable,

};



static void mscc_ocelot_release_ports(struct ocelot *ocelot)

{

	int port;



	for (port = 0; port < ocelot->num_phys_ports; port++) {

		struct ocelot_port_private *priv;

		struct ocelot_port *ocelot_port;



		ocelot_port = ocelot->ports[port];

		if (!ocelot_port)

			continue;



		priv = container_of(ocelot_port, struct ocelot_port_private,

				    port);



		unregister_netdev(priv->dev);

		free_netdev(priv->dev);

	}

}



static int mscc_ocelot_init_ports(struct platform_device *pdev,

				  struct device_node *ports)

{
@@ -1132,6 +1152,7 @@ static int mscc_ocelot_remove(struct platform_device *pdev) 
	struct ocelot *ocelot = platform_get_drvdata(pdev);



	ocelot_deinit_timestamp(ocelot);

	mscc_ocelot_release_ports(ocelot);

	ocelot_deinit(ocelot);

	unregister_switchdev_blocking_notifier(&ocelot_switchdev_blocking_nb);

	unregister_switchdev_notifier(&ocelot_switchdev_nb);