Commit 22cb8555 authored by Ofir Bitton's avatar Ofir Bitton Committed by Oded Gabbay
Browse files

habanalabs: verify queue can contain all cs jobs 



In order for the user to be aware of wrong inputs, we must return
error in case the amount of jobs per cs exceeds the corresponding
queue size.

Signed-off-by: default avatarOfir Bitton <obitton@habana.ai>
Reviewed-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
parent 5574cb21

drivers/misc/habanalabs/habanalabs.h

+4 −0
Original line number Diff line number Diff line
@@ -421,6 +421,10 @@ struct hl_cs_job; 
#define HL_QUEUE_LENGTH			4096

#define HL_QUEUE_SIZE_IN_BYTES		(HL_QUEUE_LENGTH * HL_BD_SIZE)



#if (HL_MAX_JOBS_PER_CS > HL_QUEUE_LENGTH)

#error "HL_QUEUE_LENGTH must be greater than HL_MAX_JOBS_PER_CS"

#endif



/* HL_CQ_LENGTH is in units of struct hl_cq_entry */

#define HL_CQ_LENGTH			HL_QUEUE_LENGTH

#define HL_CQ_SIZE_IN_BYTES		(HL_CQ_LENGTH * HL_CQ_ENTRY_SIZE)

drivers/misc/habanalabs/hw_queue.c

+7 −0
Original line number Diff line number Diff line
@@ -158,6 +158,13 @@ static int int_queue_sanity_checks(struct hl_device *hdev, 
{

	int free_slots_cnt;



	if (num_of_entries > q->int_queue_len) {

		dev_err(hdev->dev,

			"Cannot populate queue %u with %u jobs\n",

			q->hw_queue_id, num_of_entries);

		return -ENOMEM;

	}



	/* Check we have enough space in the queue */

	free_slots_cnt = queue_free_slots(q, q->int_queue_len);