Commit 22c80aac authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe
Browse files

blktrace: Trace remapped requests correctly 



Trace the remapped operation and its flags instead of only the data
direction of remapped operations. This issue was detected by analyzing
the warnings reported by sparse related to the new blk_opf_t type.

Reviewed-by: default avatarJun'ichi Nomura <junichi.nomura@nec.com>
Cc: Mike Snitzer <snitzer@kernel.org>
Cc: Mike Christie <michael.christie@oracle.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Chaitanya Kulkarni <kch@nvidia.com>
Fixes: 1b9a9ab7 ("blktrace: use op accessors")
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220714180729.1065367-11-bvanassche@acm.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent d625fecd

kernel/trace/blktrace.c

+1 −1
Original line number Diff line number Diff line
@@ -1058,7 +1058,7 @@ static void blk_add_trace_rq_remap(void *ignore, struct request *rq, dev_t dev, 
	r.sector_from = cpu_to_be64(from);



	__blk_add_trace(bt, blk_rq_pos(rq), blk_rq_bytes(rq),

			rq_data_dir(rq), 0, BLK_TA_REMAP, 0,

			req_op(rq), rq->cmd_flags, BLK_TA_REMAP, 0,

			sizeof(r), &r, blk_trace_request_get_cgid(rq));

	rcu_read_unlock();

}