Commit 22b737f4 authored by WANG Cong's avatar WANG Cong Committed by Tejun Heo
Browse files

percpu: refactor the code in pcpu_[de]populate_chunk() 



Using break statement at the end of a for loop is confusing,
refactor it by replacing the for loop.

Signed-off-by: default avatarWANG Cong <amwang@redhat.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 85438592

mm/percpu.c

+8 −10
Original line number Diff line number Diff line
@@ -886,11 +886,10 @@ static void pcpu_depopulate_chunk(struct pcpu_chunk *chunk, int off, int size) 
	int rs, re;



	/* quick path, check whether it's empty already */

	pcpu_for_each_unpop_region(chunk, rs, re, page_start, page_end) {

	rs = page_start;

	pcpu_next_unpop(chunk, &rs, &re, page_end);

	if (rs == page_start && re == page_end)

		return;

		break;

	}



	/* immutable chunks can't be depopulated */

	WARN_ON(chunk->immutable);
@@ -941,11 +940,10 @@ static int pcpu_populate_chunk(struct pcpu_chunk *chunk, int off, int size) 
	int rs, re, rc;



	/* quick path, check whether all pages are already there */

	pcpu_for_each_pop_region(chunk, rs, re, page_start, page_end) {

	rs = page_start;

	pcpu_next_pop(chunk, &rs, &re, page_end);

	if (rs == page_start && re == page_end)

		goto clear;

		break;

	}



	/* need to allocate and map pages, this chunk can't be immutable */

	WARN_ON(chunk->immutable);