Commit 22b67d17 authored by Petr Machata's avatar Petr Machata Committed by Jakub Kicinski
Browse files

net: rtnetlink: rtnl_stats_get(): Emit an extack for unset filter_mask 



Both get and dump handlers for RTM_GETSTATS require that a filter_mask, a
mask of which attributes should be emitted in the netlink response, is
unset. rtnl_stats_dump() does include an extack in the bounce,
rtnl_stats_get() however does not. Fix the omission.

Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/01feb1f4bbd22a19f6629503c4f366aed6424567.1645020876.git.petrm@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4d078475

net/core/rtnetlink.c

+3 −1
Original line number Diff line number Diff line
@@ -5405,8 +5405,10 @@ static int rtnl_stats_get(struct sk_buff *skb, struct nlmsghdr *nlh, 
		return -ENODEV;



	filter_mask = ifsm->filter_mask;

	if (!filter_mask)

	if (!filter_mask) {

		NL_SET_ERR_MSG(extack, "Filter mask must be set for stats get");

		return -EINVAL;

	}



	nskb = nlmsg_new(if_nlmsg_stats_size(dev, filter_mask), GFP_KERNEL);

	if (!nskb)