Commit 22955723 authored by Lang Cheng's avatar Lang Cheng Committed by Jason Gunthorpe
Browse files

RDMA/hns: Remove unused member and variable of CMDQ 

last_status of structure hns_roce_v2_cmq has never been used, and the
variable named 'complete' in __hns_roce_cmq_send() is meaningless.

Fixes: a04ff739 ("RDMA/hns: Add command queue support for hip08 RoCE driver")
Link: https://lore.kernel.org/r/1612688143-28226-2-git-send-email-liweihang@huawei.com


Signed-off-by: default avatarLang Cheng <chenglang@huawei.com>
Signed-off-by: default avatarWeihang Li <liweihang@huawei.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 633d6102

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+3 −6
Original line number Diff line number Diff line
@@ -1314,7 +1314,6 @@ static int __hns_roce_cmq_send(struct hns_roce_dev *hr_dev, 
	struct hns_roce_v2_priv *priv = hr_dev->priv;

	struct hns_roce_v2_cmq_ring *csq = &priv->cmq.csq;

	struct hns_roce_cmq_desc *desc_to_use;

	bool complete = false;

	u32 timeout = 0;

	int handle = 0;

	u16 desc_ret;
@@ -1361,7 +1360,6 @@ static int __hns_roce_cmq_send(struct hns_roce_dev *hr_dev, 
	}



	if (hns_roce_cmq_csq_done(hr_dev)) {

		complete = true;

		handle = 0;

		while (handle < num) {

			/* get the result of hardware write back */
@@ -1373,16 +1371,15 @@ static int __hns_roce_cmq_send(struct hns_roce_dev *hr_dev, 
				ret = 0;

			else

				ret = -EIO;

			priv->cmq.last_status = desc_ret;



			ntc++;

			handle++;

			if (ntc == csq->desc_num)

				ntc = 0;

		}

	}



	if (!complete)

	} else {

		ret = -EAGAIN;

	}



	/* clean the command send queue */

	handle = hns_roce_cmq_csq_clean(hr_dev);

drivers/infiniband/hw/hns/hns_roce_hw_v2.h

+0 −1
Original line number Diff line number Diff line
@@ -1890,7 +1890,6 @@ struct hns_roce_v2_cmq { 
	struct hns_roce_v2_cmq_ring csq;

	struct hns_roce_v2_cmq_ring crq;

	u16 tx_timeout;

	u16 last_status;

};



enum hns_roce_link_table_type {