Commit 2294a729 authored by Qiuxu Zhuo's avatar Qiuxu Zhuo Committed by Tony Luck
Browse files

EDAC/i10nm: Fix NVDIMM detection 



MCDDRCFG is a per-channel register and uses bit{0,1} to indicate
the NVDIMM presence on DIMM slot{0,1}. Current i10nm_edac driver
wrongly uses MCDDRCFG as per-DIMM register and fails to detect
the NVDIMM.

Fix it by reading MCDDRCFG as per-channel register and using its
bit{0,1} to check whether the NVDIMM is populated on DIMM slot{0,1}.

Fixes: d4dc89d0 ("EDAC, i10nm: Add a driver for Intel 10nm server processors")
Reported-by: default avatarFan Du <fan.du@intel.com>
Tested-by: default avatarWen Jin <wen.jin@intel.com>
Signed-off-by: default avatarQiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20210818175701.1611513-2-tony.luck@intel.com
parent fd07a4a0

drivers/edac/i10nm_base.c

+3 −3
Original line number Diff line number Diff line
@@ -33,9 +33,9 @@ 
#define I10NM_GET_DIMMMTR(m, i, j)	\

	readl((m)->mbase + ((m)->hbm_mc ? 0x80c : 0x2080c) + \

	(i) * (m)->chan_mmio_sz + (j) * 4)

#define I10NM_GET_MCDDRTCFG(m, i, j)	\

#define I10NM_GET_MCDDRTCFG(m, i)	\

	readl((m)->mbase + ((m)->hbm_mc ? 0x970 : 0x20970) + \

	(i) * (m)->chan_mmio_sz + (j) * 4)

	(i) * (m)->chan_mmio_sz)

#define I10NM_GET_MCMTR(m, i)		\

	readl((m)->mbase + ((m)->hbm_mc ? 0xef8 : 0x20ef8) + \

	(i) * (m)->chan_mmio_sz)
@@ -321,10 +321,10 @@ static int i10nm_get_dimm_config(struct mem_ctl_info *mci, 


		ndimms = 0;

		amap = I10NM_GET_AMAP(imc, i);

		mcddrtcfg = I10NM_GET_MCDDRTCFG(imc, i);

		for (j = 0; j < imc->num_dimms; j++) {

			dimm = edac_get_dimm(mci, i, j, 0);

			mtr = I10NM_GET_DIMMMTR(imc, i, j);

			mcddrtcfg = I10NM_GET_MCDDRTCFG(imc, i, j);

			edac_dbg(1, "dimmmtr 0x%x mcddrtcfg 0x%x (mc%d ch%d dimm%d)\n",

				 mtr, mcddrtcfg, imc->mc, i, j);