Commit 2274af1d authored by Pavel Skripkin's avatar Pavel Skripkin Committed by David S. Miller
Browse files

net: mii: make mii_ethtool_gset() return void 



mii_ethtool_gset() does not return any errors. Since there are no users
of this function that rely on its return value, it can be
made void.

Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9fcfd088

drivers/net/mii.c

+1 −5
Original line number Diff line number Diff line
@@ -49,10 +49,8 @@ static u32 mii_get_an(struct mii_if_info *mii, u16 addr) 
 *

 * The @ecmd parameter is expected to have been cleared before calling

 * mii_ethtool_gset().

 *

 * Returns 0 for success, negative on error.

 */

int mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)

void mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)

{

	struct net_device *dev = mii->dev;

	u16 bmcr, bmsr, ctrl1000 = 0, stat1000 = 0;
@@ -131,8 +129,6 @@ int mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd) 
	mii->full_duplex = ecmd->duplex;



	/* ignore maxtxpkt, maxrxpkt for now */



	return 0;

}



/**

include/linux/mii.h

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ struct mii_if_info { 


extern int mii_link_ok (struct mii_if_info *mii);

extern int mii_nway_restart (struct mii_if_info *mii);

extern int mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd);

extern void mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd);

extern void mii_ethtool_get_link_ksettings(

	struct mii_if_info *mii, struct ethtool_link_ksettings *cmd);

extern int mii_ethtool_sset(struct mii_if_info *mii, struct ethtool_cmd *ecmd);