Commit 22707e12 authored by Junxian Huang's avatar Junxian Huang Committed by Chengchang Tang
Browse files

RDMA/hns: Fix out-of-order issue of requester when setting FENCE 

maillist inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IB30V8
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=5dbcb1c1900f45182b5651c89257c272f1f3ead7



----------------------------------------------------------------------

The FENCE indicator in hns WQE doesn't ensure that response data from
a previous Read/Atomic operation has been written to the requester's
memory before the subsequent Send/Write operation is processed. This
may result in the subsequent Send/Write operation accessing the original
data in memory instead of the expected response data.

Unlike FENCE, the SO (Strong Order) indicator blocks the subsequent
operation until the previous response data is written to memory and a
bresp is returned. Set the SO indicator instead of FENCE to maintain
strict order.

Fixes: 9a443537 ("IB/hns: Add driver files for hns RoCE driver")
Signed-off-by: default avatarJunxian Huang <huangjunxian6@hisilicon.com>
Link: https://patch.msgid.link/20241108075743.2652258-2-huangjunxian6@hisilicon.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarXinghai Cen <cenxinghai@h-partners.com>
parent e57f091d

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+1 −1
Original line number Diff line number Diff line
@@ -673,7 +673,7 @@ static inline int set_rc_wqe(struct hns_roce_qp *qp, 
	if (WARN_ON(ret))

		return ret;



	hr_reg_write(rc_sq_wqe, RC_SEND_WQE_FENCE,

	hr_reg_write(rc_sq_wqe, RC_SEND_WQE_SO,

		     (wr->send_flags & IB_SEND_FENCE) ? 1 : 0);



	hr_reg_write(rc_sq_wqe, RC_SEND_WQE_SE,

drivers/infiniband/hw/hns/hns_roce_hw_v2.h

+1 −0
Original line number Diff line number Diff line
@@ -935,6 +935,7 @@ struct hns_roce_v2_rc_send_wqe { 
#define RC_SEND_WQE_OWNER RC_SEND_WQE_FIELD_LOC(7, 7)

#define RC_SEND_WQE_CQE RC_SEND_WQE_FIELD_LOC(8, 8)

#define RC_SEND_WQE_FENCE RC_SEND_WQE_FIELD_LOC(9, 9)

#define RC_SEND_WQE_SO RC_SEND_WQE_FIELD_LOC(10, 10)

#define RC_SEND_WQE_SE RC_SEND_WQE_FIELD_LOC(11, 11)

#define RC_SEND_WQE_INLINE RC_SEND_WQE_FIELD_LOC(12, 12)

#define RC_SEND_WQE_WQE_INDEX RC_SEND_WQE_FIELD_LOC(30, 15)