Commit 226efec2 authored by Martin KaFai Lau's avatar Martin KaFai Lau Committed by Daniel Borkmann
Browse files

selftests/bpf: Fix a fd leak in an error path in network_helpers.c 



In __start_server, it leaks a fd when setsockopt(SO_REUSEPORT) fails.
This patch fixes it.

Fixes: eed92afd ("bpf: selftest: Test batching and bpf_(get|set)sockopt in bpf tcp iter")
Reported-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Signed-off-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarYonghong Song <yhs@fb.com>
Acked-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20230316000726.1016773-2-martin.lau@linux.dev
parent ed01385c

tools/testing/selftests/bpf/network_helpers.c

+1 −1
Original line number Diff line number Diff line
@@ -95,7 +95,7 @@ static int __start_server(int type, int protocol, const struct sockaddr *addr, 
	if (reuseport &&

	    setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, &on, sizeof(on))) {

		log_err("Failed to set SO_REUSEPORT");

		return -1;

		goto error_close;

	}



	if (bind(fd, addr, addrlen) < 0) {