Commit 22683e48 authored by Jean Delvare's avatar Jean Delvare Committed by Greg Kroah-Hartman
Browse files

usb: misc: onboard_usb_hub: Drop obsolete dependency on COMPILE_TEST



Since commit 0166dc11 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Link: https://lore.kernel.org/r/20221127155230.144886b7@endymion.delvare


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ae423ef5
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -298,7 +298,7 @@ config BRCM_USB_PINMAP

config USB_ONBOARD_HUB
	tristate "Onboard USB hub support"
	depends on OF || COMPILE_TEST
	depends on OF
	help
	  Say Y here if you want to support discrete onboard USB hubs that
	  don't require an additional control bus for initialization, but