Commit 22682a07 authored by Mikulas Patocka's avatar Mikulas Patocka Committed by Borislav Petkov
Browse files

objtool: Fix objtool regression on x32 systems 



Commit c087c6e7 ("objtool: Fix type of reloc::addend") failed to
appreciate cross building from ILP32 hosts, where 'int' == 'long' and
the issue persists.

As such, use s64/int64_t/Elf64_Sxword for this field and suffer the
pain that is ISO C99 printf formats for it.

Fixes: c087c6e7 ("objtool: Fix type of reloc::addend")
Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
[peterz: reword changelog, s/long long/s64/]
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Cc: <stable@vger.kernel.org>
Link: https://lkml.kernel.org/r/alpine.LRH.2.02.2205161041260.11556@file01.intranet.prod.int.rdu2.redhat.com
parent ead165fa

tools/objtool/check.c

+5 −4
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 


#include <string.h>

#include <stdlib.h>

#include <inttypes.h>

#include <sys/mman.h>



#include <arch/elf.h>
@@ -561,12 +562,12 @@ static int add_dead_ends(struct objtool_file *file) 
		else if (reloc->addend == reloc->sym->sec->sh.sh_size) {

			insn = find_last_insn(file, reloc->sym->sec);

			if (!insn) {

				WARN("can't find unreachable insn at %s+0x%lx",

				WARN("can't find unreachable insn at %s+0x%" PRIx64,

				     reloc->sym->sec->name, reloc->addend);

				return -1;

			}

		} else {

			WARN("can't find unreachable insn at %s+0x%lx",

			WARN("can't find unreachable insn at %s+0x%" PRIx64,

			     reloc->sym->sec->name, reloc->addend);

			return -1;

		}
@@ -596,12 +597,12 @@ static int add_dead_ends(struct objtool_file *file) 
		else if (reloc->addend == reloc->sym->sec->sh.sh_size) {

			insn = find_last_insn(file, reloc->sym->sec);

			if (!insn) {

				WARN("can't find reachable insn at %s+0x%lx",

				WARN("can't find reachable insn at %s+0x%" PRIx64,

				     reloc->sym->sec->name, reloc->addend);

				return -1;

			}

		} else {

			WARN("can't find reachable insn at %s+0x%lx",

			WARN("can't find reachable insn at %s+0x%" PRIx64,

			     reloc->sym->sec->name, reloc->addend);

			return -1;

		}

tools/objtool/elf.c

+1 −1
Original line number Diff line number Diff line
@@ -550,7 +550,7 @@ static struct section *elf_create_reloc_section(struct elf *elf, 
						int reltype);



int elf_add_reloc(struct elf *elf, struct section *sec, unsigned long offset,

		  unsigned int type, struct symbol *sym, long addend)

		  unsigned int type, struct symbol *sym, s64 addend)

{

	struct reloc *reloc;

tools/objtool/include/objtool/elf.h

+2 −2
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ struct reloc { 
	struct symbol *sym;

	unsigned long offset;

	unsigned int type;

	long addend;

	s64 addend;

	int idx;

	bool jump_table_start;

};
@@ -145,7 +145,7 @@ struct elf *elf_open_read(const char *name, int flags); 
struct section *elf_create_section(struct elf *elf, const char *name, unsigned int sh_flags, size_t entsize, int nr);



int elf_add_reloc(struct elf *elf, struct section *sec, unsigned long offset,

		  unsigned int type, struct symbol *sym, long addend);

		  unsigned int type, struct symbol *sym, s64 addend);

int elf_add_reloc_to_insn(struct elf *elf, struct section *sec,

			  unsigned long offset, unsigned int type,

			  struct section *insn_sec, unsigned long insn_off);