Commit 225a2ec1 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski
Browse files

pinctrl: samsung: Fix missing OF and GPIOLIB dependency on S3C24xx and S3C64xx 



All Samsung pinctrl drivers select common part - PINCTRL_SAMSUNG which uses
both OF and GPIOLIB inside.  However only Exynos drivers depend on these,
therefore after enabling COMPILE_TEST, on x86_64 build of S3C64xx driver
failed:

    drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpiolib_register’:
    drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: ‘struct gpio_chip’ has no member named ‘of_node’
       gc->of_node = bank->of_node;
         ^

Rework the dependencies so all Samsung drivers and common
PINCTRL_SAMSUNG part depend on OF_GPIO (which is default yes if GPIOLIB
and OF are enabled).

Reported-by: default avatarChen Zhou <chenzhou10@huawei.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
parent 56d9625e

drivers/pinctrl/samsung/Kconfig

+4 −2
Original line number Diff line number Diff line
@@ -4,12 +4,13 @@ 
#

config PINCTRL_SAMSUNG

	bool

	depends on OF_GPIO

	select PINMUX

	select PINCONF



config PINCTRL_EXYNOS

	bool "Pinctrl common driver part for Samsung Exynos SoCs"

	depends on OF && GPIOLIB

	depends on OF_GPIO

	depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST

	select PINCTRL_SAMSUNG

	select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210)
@@ -25,11 +26,12 @@ config PINCTRL_EXYNOS_ARM64 


config PINCTRL_S3C24XX

	bool "Samsung S3C24XX SoC pinctrl driver"

	depends on OF

	depends on OF_GPIO

	depends on ARCH_S3C24XX || COMPILE_TEST

	select PINCTRL_SAMSUNG



config PINCTRL_S3C64XX

	bool "Samsung S3C64XX SoC pinctrl driver"

	depends on OF_GPIO

	depends on ARCH_S3C64XX || COMPILE_TEST

	select PINCTRL_SAMSUNG