Commit 221e8360 authored by Yang Yingliang's avatar Yang Yingliang Committed by Jens Axboe
Browse files

n64cart: fix return value check in n64cart_probe() 



In case of error, the function devm_platform_ioremap_resource()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Fixes: d9b2a2bb ("block: Add n64 cart driver")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20210909090608.2989716-1-yangyingliang@huawei.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 7f2a6a69

drivers/block/n64cart.c

+2 −2
Original line number Diff line number Diff line
@@ -129,8 +129,8 @@ static int __init n64cart_probe(struct platform_device *pdev) 
	}



	reg_base = devm_platform_ioremap_resource(pdev, 0);

	if (!reg_base)

		return -EINVAL;

	if (IS_ERR(reg_base))

		return PTR_ERR(reg_base);



	disk = blk_alloc_disk(NUMA_NO_NODE);

	if (!disk)