Commit 220fafb4 authored by Liang He's avatar Liang He Committed by Greg Kroah-Hartman
Browse files

usb: aspeed-vhub: Fix refcount leak bug in ast_vhub_init_desc() 



We should call of_node_put() for the reference returned by
of_get_child_by_name() which has increased the refcount.

Fixes: 30d2617f ("usb: gadget: aspeed: allow to set usb strings in device tree")
Signed-off-by: default avatarLiang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220713120528.368168-1-windhl@126.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent efa2bebf

drivers/usb/gadget/udc/aspeed-vhub/hub.c

+3 −1
Original line number Diff line number Diff line
@@ -1059,8 +1059,10 @@ static int ast_vhub_init_desc(struct ast_vhub *vhub) 
	/* Initialize vhub String Descriptors. */

	INIT_LIST_HEAD(&vhub->vhub_str_desc);

	desc_np = of_get_child_by_name(vhub_np, "vhub-strings");

	if (desc_np)

	if (desc_np) {

		ret = ast_vhub_of_parse_str_desc(vhub, desc_np);

		of_node_put(desc_np);

	}

	else

		ret = ast_vhub_str_alloc_add(vhub, &ast_vhub_strings);