Commit 2203718c authored Jun 07, 2023 by Georgi Valkov Committed by David S. Miller Jun 09, 2023

usbnet: ipheth: fix risk of NULL pointer deallocation



The cleanup precedure in ipheth_probe will attempt to free a
NULL pointer in dev->ctrl_buf if the memory allocation for
this buffer is not successful. While kfree ignores NULL pointers,
and the existing code is safe, it is a better design to rearrange
the goto labels and avoid this.

Signed-off-by: Georgi Valkov <gvalkov@gmail.com>
Signed-off-by: Foster Snowhill <forst@pen.gy>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fd5f4d7d

drivers/net/usb/ipheth.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -510,8 +510,8 @@ static int ipheth_probe(struct usb_interface *intf,
		ipheth_free_urbs(dev);
		err_alloc_urbs:
		err_get_macaddr:
		err_alloc_ctrl_buf:
		kfree(dev->ctrl_buf);
		err_alloc_ctrl_buf:
		err_endpoints:
		free_netdev(netdev);
		return retval;