Commit 21e9a838 authored by Hui Tang's avatar Hui Tang Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init() 



Because of the possilble failure of devm_kzalloc(), dpu_wb_conn might
be NULL and will cause null pointer dereference later.

Therefore, it might be better to check it and directly return -ENOMEM.

Fixes: 77b001ac ("drm/msm/dpu: add the writeback connector layer")
Signed-off-by: default avatarHui Tang <tanghui20@huawei.com>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/512277/
Link: https://lore.kernel.org/r/20221119055518.179937-1-tanghui20@huawei.com


[DB: fixed typo in commit message]
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent a685d27f

drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c

+2 −0
Original line number Diff line number Diff line
@@ -70,6 +70,8 @@ int dpu_writeback_init(struct drm_device *dev, struct drm_encoder *enc, 
	int rc = 0;



	dpu_wb_conn = devm_kzalloc(dev->dev, sizeof(*dpu_wb_conn), GFP_KERNEL);

	if (!dpu_wb_conn)

		return -ENOMEM;



	drm_connector_helper_add(&dpu_wb_conn->base.base, &dpu_wb_conn_helper_funcs);