Commit 21dd1fd6 authored by Hyunchul Lee's avatar Hyunchul Lee Committed by Namjae Jeon
Browse files

ksmbd: handle error cases first in smb2_create_sd_buffers 



For code cleanup, handle error cases first in
smb2_create_sd_buffers().

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: default avatarNamjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent ce154c32

fs/ksmbd/smb2pdu.c

+11 −13
Original line number Diff line number Diff line
@@ -2319,27 +2319,25 @@ static int smb2_create_sd_buffer(struct ksmbd_work *work, 
				 struct path *path)

{

	struct create_context *context;

	int rc = -ENOENT;

	struct create_sd_buf_req *sd_buf;



	if (!req->CreateContextsOffset)

		return rc;

		return -ENOENT;



	/* Parse SD BUFFER create contexts */

	context = smb2_find_context_vals(req, SMB2_CREATE_SD_BUFFER);

	if (context && !IS_ERR(context)) {

		struct create_sd_buf_req *sd_buf;

	if (!context)

		return -ENOENT;

	else if (IS_ERR(context))

		return PTR_ERR(context);



	ksmbd_debug(SMB,

		    "Set ACLs using SMB2_CREATE_SD_BUFFER context\n");

	sd_buf = (struct create_sd_buf_req *)context;

		rc = set_info_sec(work->conn, work->tcon,

				  path, &sd_buf->ntsd,

	return set_info_sec(work->conn, work->tcon, path, &sd_buf->ntsd,

			    le32_to_cpu(sd_buf->ccontext.DataLength), true);

}



	return rc;

}



static void ksmbd_acls_fattr(struct smb_fattr *fattr, struct inode *inode)

{

	fattr->cf_uid = inode->i_uid;