Commit 21d8c25e authored by Vinay Kumar Yadav's avatar Vinay Kumar Yadav Committed by David S. Miller
Browse files

ch_ktls: tcb close causes tls connection failure 



HW doesn't need marking TCB closed. This TCB state change
sometimes causes problem to the new connection which gets
the same tid.

Fixes: 34aba2c4 ("cxgb4/chcr : Register to tls add and del callback")
Signed-off-by: default avatarVinay Kumar Yadav <vinay.yadav@chelsio.com>
Signed-off-by: default avatarRohit Maheshwari <rohitm@chelsio.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bc16efd2

drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c

+0 −19
Original line number Diff line number Diff line
@@ -349,18 +349,6 @@ static int chcr_set_tcb_field(struct chcr_ktls_info *tx_info, u16 word, 
	return cxgb4_ofld_send(tx_info->netdev, skb);

}



/*

 * chcr_ktls_mark_tcb_close: mark tcb state to CLOSE

 * @tx_info - driver specific tls info.

 * return: NET_TX_OK/NET_XMIT_DROP.

 */

static int chcr_ktls_mark_tcb_close(struct chcr_ktls_info *tx_info)

{

	return chcr_set_tcb_field(tx_info, TCB_T_STATE_W,

				  TCB_T_STATE_V(TCB_T_STATE_M),

				  CHCR_TCB_STATE_CLOSED, 1);

}



/*

 * chcr_ktls_dev_del:  call back for tls_dev_del.

 * Remove the tid and l2t entry and close the connection.
@@ -395,8 +383,6 @@ static void chcr_ktls_dev_del(struct net_device *netdev, 


	/* clear tid */

	if (tx_info->tid != -1) {

		/* clear tcb state and then release tid */

		chcr_ktls_mark_tcb_close(tx_info);

		cxgb4_remove_tid(&tx_info->adap->tids, tx_info->tx_chan,

				 tx_info->tid, tx_info->ip_family);

	}
@@ -574,7 +560,6 @@ static int chcr_ktls_dev_add(struct net_device *netdev, struct sock *sk, 
	return 0;



free_tid:

	chcr_ktls_mark_tcb_close(tx_info);

#if IS_ENABLED(CONFIG_IPV6)

	/* clear clip entry */

	if (tx_info->ip_family == AF_INET6)
@@ -672,10 +657,6 @@ static int chcr_ktls_cpl_act_open_rpl(struct adapter *adap, 
	if (tx_info->pending_close) {

		spin_unlock(&tx_info->lock);

		if (!status) {

			/* it's a late success, tcb status is established,

			 * mark it close.

			 */

			chcr_ktls_mark_tcb_close(tx_info);

			cxgb4_remove_tid(&tx_info->adap->tids, tx_info->tx_chan,

					 tid, tx_info->ip_family);

		}