Commit 21cdd6a0 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

usb: musb: mpfs: Fix error codes in probe() 



These error paths return success but they need to return a negative
error code.

Fixes: 7a96b6ea ("usb: musb: Add support for PolarFire SoC's musb controller")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YrVmLEc/FOEzNdzj@kili


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 105f3fd2

drivers/usb/musb/mpfs.c

+4 −1
Original line number Diff line number Diff line
@@ -181,8 +181,10 @@ static int mpfs_probe(struct platform_device *pdev) 
	glue->clk = clk;



	pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);

	if (!pdata)

	if (!pdata) {

		ret = -ENOMEM;

		goto err_clk_disable;

	}



	pdata->config = &mpfs_musb_hdrc_config;

	pdata->platform_ops = &mpfs_ops;
@@ -197,6 +199,7 @@ static int mpfs_probe(struct platform_device *pdev) 
	if (IS_ERR(glue->phy)) {

		dev_err(dev, "failed to register usb-phy %ld\n",

			PTR_ERR(glue->phy));

		ret = PTR_ERR(glue->phy);

		goto err_clk_disable;

	}