Commit 21c7e972 authored by Luo Jiaxing's avatar Luo Jiaxing Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: Disable SATA disk phy for severe I_T nexus reset failure 

If the softreset fails in the I_T reset, libsas will then continue to issue
a controller reset to try to recover.

However a faulty disk may cause the softreset to fail, and resetting the
controller will not help this scenario. Indeed, we will just continue the
cycle of error handle handling to try to recover.

So if the softreset fails upon certain conditions, just disable the phy
associated with the disk. The user needs to handle this problem.

Link: https://lore.kernel.org/r/1634041588-74824-5-git-send-email-john.garry@huawei.com


Signed-off-by: default avatarLuo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 00aeaf32

drivers/scsi/hisi_sas/hisi_sas_main.c

+24 −5
Original line number Diff line number Diff line
@@ -1870,13 +1870,32 @@ static int hisi_sas_I_T_nexus_reset(struct domain_device *device) 
	}

	hisi_sas_dereg_device(hisi_hba, device);



	if (dev_is_sata(device)) {

	rc = hisi_sas_debug_I_T_nexus_reset(device);

	if (rc == TMF_RESP_FUNC_COMPLETE && dev_is_sata(device)) {

		struct sas_phy *local_phy;



		rc = hisi_sas_softreset_ata_disk(device);

		if (rc == TMF_RESP_FUNC_FAILED)

			return TMF_RESP_FUNC_FAILED;

		switch (rc) {

		case -ECOMM:

			rc = -ENODEV;

			break;

		case TMF_RESP_FUNC_FAILED:

		case -EMSGSIZE:

		case -EIO:

			local_phy = sas_get_local_phy(device);

			rc = sas_phy_enable(local_phy, 0);

			if (!rc) {

				local_phy->enabled = 0;

				dev_err(dev, "Disabled local phy of ATA disk %016llx due to softreset fail (%d)\n",

					SAS_ADDR(device->sas_addr), rc);

				rc = -ENODEV;

			}

			sas_put_local_phy(local_phy);

			break;

		default:

			break;

		}

	}



	rc = hisi_sas_debug_I_T_nexus_reset(device);



	if ((rc == TMF_RESP_FUNC_COMPLETE) || (rc == -ENODEV))

		hisi_sas_release_task(hisi_hba, device);