Commit 21a9acc1 authored by Dongliang Mu's avatar Dongliang Mu Committed by Bartosz Golaszewski
Browse files

gpio: tqmx86: fix uninitialized variable girq 



The commit 92461060 ("gpio: tpmx86: Move PM device over to
irq domain") adds a dereference of girq that may be uninitialized.

Fix this by moving irq_domain_set_pm_device into if true branch
as suggested by Marc Zyngier.

Fixes: 92461060 ("gpio: tpmx86: Move PM device over to irq domain")
Suggested-by: default avatarMarc Zyngier <maz@kernel.org>
Signed-off-by: default avatarDongliang Mu <mudongliangabcd@gmail.com>
Acked-by: default avatarMarc Zyngier <maz@kernel.org>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent ab637d48

drivers/gpio/gpio-tqmx86.c

+2 −2
Original line number Diff line number Diff line
@@ -307,6 +307,8 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) 
		girq->default_type = IRQ_TYPE_NONE;

		girq->handler = handle_simple_irq;

		girq->init_valid_mask = tqmx86_init_irq_valid_mask;



		irq_domain_set_pm_device(girq->domain, dev);

	}



	ret = devm_gpiochip_add_data(dev, chip, gpio);
@@ -315,8 +317,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) 
		goto out_pm_dis;

	}



	irq_domain_set_pm_device(girq->domain, dev);



	dev_info(dev, "GPIO functionality initialized with %d pins\n",

		 chip->ngpio);