Commit 21a6cd48 authored by Tom Rix's avatar Tom Rix Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Initialize variable in qla8044_poll_reg() 

clang static analysis reports this problem:

qla_nx2.c:694:3: warning: 6th function call argument is
  an uninitialized value
        ql_log(ql_log_fatal, vha, 0xb090,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In qla8044_poll_reg(), when reading the reg fails, the error is reported by
reusing the timeout error reporter.  Because the value is unset, a garbage
value will be reported.  Initialize the value.

Link: https://lore.kernel.org/r/20201005144544.25335-1-trix@redhat.com


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 657ed8a8

drivers/scsi/qla2xxx/qla_nx2.c

+1 −1
Original line number Diff line number Diff line
@@ -660,7 +660,7 @@ static int 
qla8044_poll_reg(struct scsi_qla_host *vha, uint32_t addr,

	int duration, uint32_t test_mask, uint32_t test_result)

{

	uint32_t value;

	uint32_t value = 0;

	int timeout_error;

	uint8_t retries;

	int ret_val = QLA_SUCCESS;