Commit 21a2960d authored by Rick Wertenbroek's avatar Rick Wertenbroek Committed by Lorenzo Pieralisi
Browse files

dt-bindings: PCI: Update the RK3399 example to a valid one 

Update the example in the documentation to a valid example.
Address for mem-base was invalid, it pointed to address
0x8000'0000 which is the upper region of the DDR which
is not necessarily populated depending on the board.
This address should point to the base of the memory
window region of the controller which is 0xfa00'0000.
Add missing pinctrl.

Link: https://lore.kernel.org/r/20230418074700.1083505-7-rick.wertenbroek@gmail.com


Signed-off-by: default avatarRick Wertenbroek <rick.wertenbroek@gmail.com>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Acked-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent 9dd3c7c4

Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml

+3 −1
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ examples: 


        pcie-ep@f8000000 {

            compatible = "rockchip,rk3399-pcie-ep";

            reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0x80000000 0x0 0x20000>;

            reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0xfa000000 0x0 0x2000000>;

            reg-names = "apb-base", "mem-base";

            clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>,

              <&cru PCLK_PCIE>, <&cru SCLK_PCIE_PM>;
@@ -63,6 +63,8 @@ examples: 
            phys = <&pcie_phy 0>, <&pcie_phy 1>, <&pcie_phy 2>, <&pcie_phy 3>;

            phy-names = "pcie-phy-0", "pcie-phy-1", "pcie-phy-2", "pcie-phy-3";

            rockchip,max-outbound-regions = <16>;

            pinctrl-names = "default";

            pinctrl-0 = <&pcie_clkreqnb_cpm>;

        };

    };

...