Unverified Commit 2111c3c0 authored Feb 15, 2021 by Randy Dunlap Committed by Christian Brauner Mar 23, 2021

namei: fix kernel-doc for struct renamedata and more

Fix kernel-doc warnings in namei.c:

../fs/namei.c:1149: warning: Excess function parameter 'dir_mode' description in 'may_create_in_sticky'
../fs/namei.c:1149: warning: Excess function parameter 'dir_uid' description in 'may_create_in_sticky'
../fs/namei.c:3396: warning: Function parameter or member 'open_flag' not described in 'vfs_tmpfile'
../fs/namei.c:3396: warning: Excess function parameter 'open_flags' description in 'vfs_tmpfile'
../fs/namei.c:4460: warning: Function parameter or member 'rd' not described in 'vfs_rename'
../fs/namei.c:4460: warning: Excess function parameter 'old_mnt_userns' description in 'vfs_rename'
../fs/namei.c:4460: warning: Excess function parameter 'old_dir' description in 'vfs_rename'
../fs/namei.c:4460: warning: Excess function parameter 'old_dentry' description in 'vfs_rename'
../fs/namei.c:4460: warning: Excess function parameter 'new_mnt_userns' description in 'vfs_rename'
../fs/namei.c:4460: warning: Excess function parameter 'new_dir' description in 'vfs_rename'
../fs/namei.c:4460: warning: Excess function parameter 'new_dentry' description in 'vfs_rename'
../fs/namei.c:4460: warning: Excess function parameter 'delegated_inode' description in 'vfs_rename'
../fs/namei.c:4460: warning: Excess function parameter 'flags' description in 'vfs_rename'

Link: https://lore.kernel.org/r/20210216042929.8931-3-rdunlap@infradead.org


Fixes: 9fe61450 ("namei: introduce struct renamedata")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: Christian Brauner <christian.brauner@ubuntu.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

parent 59347d99

fs/namei.c

+3 −11

Original line number	Diff line number	Diff line
		@@ -1122,8 +1122,7 @@ int may_linkat(struct user_namespace mnt_userns, struct path link)
		* should be allowed, or not, on files that already
		* exist.
		* @mnt_userns: user namespace of the mount the inode was found from
		* @dir_mode: mode bits of directory
		* @dir_uid: owner of directory
		* @nd: nameidata pathwalk data
		* @inode: the inode of the file to open
		*
		* Block an O_CREAT open of a FIFO (or a regular file) when:
		@@ -3381,7 +3380,7 @@ static int do_open(struct nameidata *nd,
		* @mnt_userns: user namespace of the mount the inode was found from
		* @dentry: pointer to dentry of the base directory
		* @mode: mode of the new tmpfile
		* @open_flags: flags
		* @open_flag: flags
		*
		* Create a temporary file.
		*
		@@ -4406,14 +4405,7 @@ SYSCALL_DEFINE2(link, const char __user , oldname, const char __user , newname

		/**
		* vfs_rename - rename a filesystem object
		* @old_mnt_userns: old user namespace of the mount the inode was found from
		* @old_dir: parent of source
		* @old_dentry: source
		* @new_mnt_userns: new user namespace of the mount the inode was found from
		* @new_dir: parent of destination
		* @new_dentry: destination
		* @delegated_inode: returns an inode needing a delegation break
		* @flags: rename flags
		* @rd: pointer to &struct renamedata info
		*
		* The caller must hold multiple mutexes--see lock_rename()).
		*