Commit 20e76d3d authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller
Browse files

net: ethernet: ixp4xx: Fix return value check in ixp4xx_eth_probe() 



In case of error, the function mdiobus_get_phy() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 05ff8435

drivers/net/ethernet/xscale/ixp4xx_eth.c

+2 −2
Original line number Diff line number Diff line
@@ -1531,8 +1531,8 @@ static int ixp4xx_eth_probe(struct platform_device *pdev) 
		phydev = of_phy_get_and_connect(ndev, np, ixp4xx_adjust_link);

	} else {

		phydev = mdiobus_get_phy(mdio_bus, plat->phy);

		if (IS_ERR(phydev)) {

			err = PTR_ERR(phydev);

		if (!phydev) {

			err = -ENODEV;

			dev_err(dev, "could not connect phydev (%d)\n", err);

			goto err_free_mem;

		}