Commit 20e2bcc4 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe
Browse files

RDMA/core: Remove protection from wrong in-kernel API usage 

The ib_create_named_qp() is kernel verb that is not used for user supplied
attributes. In such case, it is ULP responsibility to provide valid QP
attributes.

In-kernel API shouldn't check it, exactly like other functions that don't
check device capabilities.

Link: https://lore.kernel.org/r/b9b9e981d1af148b750750196e686199dbbf61f8.1628014762.git.leonro@nvidia.com


Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 8fc3beeb

drivers/infiniband/core/verbs.c

+0 −10
Original line number Diff line number Diff line
@@ -1219,16 +1219,6 @@ struct ib_qp *ib_create_named_qp(struct ib_pd *pd, 
	struct ib_qp *qp;

	int ret;



	if (qp_init_attr->rwq_ind_tbl &&

	    (qp_init_attr->recv_cq ||

	    qp_init_attr->srq || qp_init_attr->cap.max_recv_wr ||

	    qp_init_attr->cap.max_recv_sge))

		return ERR_PTR(-EINVAL);



	if ((qp_init_attr->create_flags & IB_QP_CREATE_INTEGRITY_EN) &&

	    !(device->attrs.device_cap_flags & IB_DEVICE_INTEGRITY_HANDOVER))

		return ERR_PTR(-EINVAL);



	/*

	 * If the callers is using the RDMA API calculate the resources

	 * needed for the RDMA READ/WRITE operations.