Commit 20aaef52 authored by Tadeusz Struk's avatar Tadeusz Struk Committed by Martin K. Petersen
Browse files

scsi: scsi_ioctl: Validate command size 

Need to make sure the command size is valid before copying the command from
user space.

Link: https://lore.kernel.org/r/20211103170659.22151-1-tadeusz.struk@linaro.org


Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: James E.J. Bottomley <jejb@linux.ibm.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Cc: <stable@vger.kernel.org> # 5.15, 5.14, 5.10
Signed-off-by: default avatarTadeusz Struk <tadeusz.struk@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9ec5128a

drivers/scsi/scsi_ioctl.c

+2 −0
Original line number Diff line number Diff line
@@ -347,6 +347,8 @@ static int scsi_fill_sghdr_rq(struct scsi_device *sdev, struct request *rq, 
{

	struct scsi_request *req = scsi_req(rq);



	if (hdr->cmd_len < 6)

		return -EMSGSIZE;

	if (copy_from_user(req->cmd, hdr->cmdp, hdr->cmd_len))

		return -EFAULT;

	if (!scsi_cmd_allowed(req->cmd, mode))